Master effective code review practices to provide constructive feedback, catch bugs early, and foster knowledge sharing while maintaining team morale. Use when reviewing pull requests, establishing review standards, or mentoring developers.

Code Review Excellence Transform code reviews from gatekeeping to knowledge sharing through constructive feedback, systematic analysis, and collaborative improvement. When to Use This Skill Reviewing pull requests and code changes Establishing code review standards for teams Mentoring junior developers through reviews Conducting architecture reviews Creating review checklists and guidelines Improving team collaboration Reducing code review cycle time Maintaining code quality standards Core Principles 1. The Review Mindset Goals of Code Review: Catch bugs and edge cases Ensure code maintainability Share knowledge across team Enforce coding standards Improve design and architecture Build team culture Not the Goals: Show off knowledge Nitpick formatting (use linters) Block progress unnecessarily Rewrite to your preference 2. Effective Feedback Good Feedback is: Specific and actionable Educational, not judgmental Focused on the code, not the person Balanced (praise good work too) Prioritized (critical vs nice to have) 3. Review Scope What to Review: Logic correctness and edge cases Security vulnerabilities Performance implications Test coverage and quality Error handling Documentation and comments API design and naming Architectural fit What Not to Review Manually: Code formatting (use Prettier, Black, etc.) Import organization Linting violations Simple typos Review Process Phase 1: Context Gathering (2 3 minutes) Phase 2: High Level Review (5 10 minutes) Phase 3: Line by Line Review (10 20 minutes) Phase 4: Summary & Decision (2 3 minutes) Review Techniques Technique 1: The Checklist Method Technique 2: The Question Approach Instead of stating problems, ask questions to encourage thinking: Technique 3: Suggest, Don't Command Technique 4: Differentiate Severity Language Specific Patterns Python Code Review TypeScript/JavaScript Code Review Advanced Review Patterns Pattern 1: Architectural Review Pattern 2: Test Quality Review Pattern 3: Security Review Giving Difficult Feedback Pattern: The Sandwich Method (Modified) Handling Disagreements Best Practices 1. Review Promptly : Within 24 hours, ideally same day 2. Limit PR Size : 200 400 lines max for effective review 3. Review in Time Blocks : 60 minutes max, take breaks 4. Use Review Tools : GitHub, GitLab, or dedicated tools 5. Automate What You Can : Linters, formatters, security scans 6. Build Rapport : Emoji, praise, and empathy matter 7. Be Available : Offer to pair on complex issues 8. Learn from Others : Review others' review comments Common Pitfalls Perfectionism : Blocking PRs for minor style preferences Scope Creep : "While you're at it, can you also..." Inconsistency : Different standards for different people Delayed Reviews : Letting PRs sit for days Ghosting : Requesting changes then disappearing Rubber Stamping : Approving without actually reviewing Bike Shedding : Debating trivial details extensively Templates PR Review Comment Template

code-review-excellence